Update macOS PATH shenanigans#12873
Merged
Merged
Conversation
One, the brew prefix differs on aarch64 hosts, two, this was completely nuts: the homebrew install process already handles that via an `eval $(brew shellenv)` in the shell profile. Fix koreader#12868
benoit-pierre
approved these changes
Dec 8, 2024
Member
Did they change that? I'm reasonably sure I had to add or execute that manually. |
Frenzie
approved these changes
Dec 8, 2024
Member
Author
They stop short of (permanently) doing it for you, but it's pretty straightforward: |
Member
|
Yes, that's what I mean. I'd be inclined to remove it fully really because brew tells you all about it. But you phrased that as if it were automated. :) |
Member
Author
|
That's a relatively fair point: you wouldn't even be able to invoke |
…ven be able to invoke brew at all if this weren't already the case.
benoit-pierre
approved these changes
Dec 8, 2024
Frenzie
approved these changes
Dec 8, 2024
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
Drop the sentence about brew being in PATH altogether: you wouldn't even be able to invoke brew at all if this weren't already the case. Fix koreader#12868
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One, the brew prefix differs on aarch64 hosts, two, this was completely nuts: the homebrew install process already handles that via an
eval $(brew shellenv)in the shell profile.Fix #12868
This change is