CoverBrowser BookInfoManager: lite getDocProps()#12936
Merged
Merged
Conversation
poire-z
approved these changes
Dec 26, 2024
poire-z
left a comment
poire-z
left a comment
Contributor
There was a problem hiding this comment.
OK.
(There's always the chance that a user have disabled the coverbrowser plugin, did stuff, re-enabled the plugin - and he gets outdated metadata. No idea how such outdated stuff can happen already before this PR, so I let you appreciate if this can introduce new issues, or if we have already opened that door - and didn't see any report.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When available, use CoverBrowser sql base to get (already customized) doc props.
Should be faster than
DocSettings:open().(Also revert my erroneous change to IconButton)
This change is