PathChooser: title bar fm_style#12942
Merged
Merged
Conversation
poire-z
approved these changes
Dec 26, 2024
poire-z
left a comment
poire-z
left a comment
Contributor
There was a problem hiding this comment.
Just tested Wiki settings > Set Save as EPUB folder, and the home and the close cross icons looks really and surprisingly tiny.
Looks way better with title_bar_fm_style=true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding #12941.
Re-extraction of covers is triggered in the "choose file" dilalog, i.e. PathChooser.
I cannot reproduce on Kindle, assume the reason of the issue is different styles of the title bar in FM/Collections and PathChooser (small icons). Assume, on some screen resolutions (because of rounding in
scaleBySize) this may cause different titlebar height and hence different cover thumbnail sizes:koreader/frontend/ui/widget/menu.lua
Lines 707 to 708 in 33af380
In any case, let the title bar be the same in all windows supported by CoverBrowser (FM, Coll, Hist, PathChooser), hoping it fixes the issue.
This change is