EPUB: unify include_images logic#13063
Merged
Frenzie merged 1 commit intokoreader:masterfrom Jan 14, 2025
Merged
Conversation
Frenzie
commented
Jan 13, 2025
Frenzie
force-pushed
the
epub-unify
branch
2 times, most recently
from
0b78eb6 to
bf1f851
Compare
Other than the slightly different InfoMessage.
Frenzie
commented
Jan 13, 2025
| -- by tapping while the InfoMessage is displayed | ||
| -- We use the fast_refresh option from image #2 for a quicker download | ||
| local go_on = UI:info(T(_("%1\n\nRetrieving image %2 / %3 …"), message, inum, nb_images), inum >= 2) | ||
| local go_on = UI:info((message and message ~= "" and message .. "\n\n" or "") .. T(_("Retrieving image %1 / %2 …"), inum, nb_images), inum >= 2) |
Member
Author
There was a problem hiding this comment.
In frontend/ui/wikipedia.lua this line reads:
local go_on = UI:info(T(_("Retrieving image %1 / %2 …"), inum, nb_images), inum >= 2)All the other changes merely serve to make these lines identical to wikipedia.lua.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other than the slightly different InfoMessage.
This change is