kosync: Make sure there are no leading or trailing whitespaces.#13077
Merged
Conversation
Member
|
I think it should either be trimmed automatically or give a better error message than "invalid username". |
This reverts commit 9f57e26.
Frenzie
reviewed
Jan 16, 2025
Frenzie
left a comment
Frenzie
left a comment
Member
There was a problem hiding this comment.
We don't need to add a new trim function, otherwise lgtm 👍
Of course we use the existing trim function. Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
Commodore64user
pushed a commit
to Commodore64user/KOReader_fork
that referenced
this pull request
Jan 27, 2025
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #13076 (if desired).
As said in the issue, one disadvantage is that existing (in my opinion incorrect) user names would become invalid.
(Another one is that since validate() is also used for passwords, it won't be possible to have whitespaces in passwords.)
This change is