BookShortcuts: open file with associated provider#13106
Merged
Conversation
Frenzie
reviewed
Jan 20, 2025
Frenzie
reviewed
Jan 20, 2025
| end | ||
| local mode = lfs.attributes(k, "mode") | ||
| if mode then | ||
| local title = T(_("Open %1"), mode == "file" and k:gsub(".*/", "") or k) |
Member
There was a problem hiding this comment.
Might be worth a quick translator's comment that it's a filename.
Frenzie
approved these changes
Jan 20, 2025
Member
|
Nice touch, those file type icons. 👍 |
Contributor
|
Why does the second item have an icon of a trash bin? Sorry, I am not quite dolphin the development of shortcuts |
Member
Author
Deleted file. |
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
Commodore64user
pushed a commit
to Commodore64user/KOReader_fork
that referenced
this pull request
Jan 27, 2025
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, viewing crash.log in TextViewer can be assigned to a gesture or a profile.
Also menu prettify.
This change is