Highlights: quicker Style and Note marker dialogs

[hius07]

Immediate effect, saving two taps as discussed in #13187.

---

This change is 

[poire-z]

If I tap on a previously made highlight, I will get that popup directly instead of the one with arrows to extend the highlight ?
Or do I still get the one with arrows, and only after taping one of its button I get this popup ?

[hius07]

Or do I still get the one with arrows, and only after taping one of its button I get this popup ?

This.

[hius07]

RadioButton widget required pressing Apply and Close buttons.
It is changed to ButtonDialog with immediate effect.

[hius07]

It would be good to change the Color dialog in the same way, but we do not have colored buttons.

[Galunid]

I'm not sure if making this a new default is a good idea. While I really like the new menu compared to the old radio buttons one, I definitely prefer "generic" menu as a default tap-on-highlight action, since I don't change highlight style at all, but often use buttons to adjust the highlighted text. This mostly comes down to preference. I don't think it warrants change of default behavior, but that's debatable.

I'd propose adding new action in Highlights menu "Ask"/"Customize". It should show this popup when the user finishes text selection. Customize could show both Style/Color adjustment.

In that case tap-on-highlight could still show the "generic" menu and user would still have the ability to customize highlights as soon as they are made.

This is meant more as a food for thought rather than critique of the PR. I'm not arguing whether it should/shouldn't be merged.

[hius07]

Thanks for the ideas.
No changes to the 'generic' Highlight menu. This new menu just replaces radio-buttons widget that is called by pressing the Style button in the original Highlight menu.

[hius07]

The same for Note marker dialog:

[NiLuJe]

Oh, nice :). That instance variable was indeed awkward!