Skip to content

fix: Added OSS-Dict support#13224

Merged
pazos merged 3 commits into
koreader:masterfrom
farfromrefug:patch-1
Feb 10, 2025
Merged

fix: Added OSS-Dict support#13224
pazos merged 3 commits into
koreader:masterfrom
farfromrefug:patch-1

Conversation

@farfromrefug

@farfromrefug farfromrefug commented Feb 8, 2025

Copy link
Copy Markdown
Contributor

Added a new entry for OSS-Dict https://github.com/farfromrefug/OSS-Dict Not sure about the last value for the dict. Cant find where you use it


This change is Reviewable

Added a new entry for OSS-Dict https://github.com/farfromrefug/OSS-Dict
Not sure about the last value for the dict. Cant find where you use it
@Frenzie Frenzie added this to the 2025.02 milestone Feb 8, 2025
@Frenzie Frenzie added the Android label Feb 8, 2025
@Frenzie

Frenzie commented Feb 8, 2025

Copy link
Copy Markdown
Member

It's the action iirc.

@farfromrefug

Copy link
Copy Markdown
Contributor Author

@Frenzie so it is a "koreader" thing? Not sure what i should put looking at others

@Frenzie

Frenzie commented Feb 9, 2025

Copy link
Copy Markdown
Member

No, like intents.

@farfromrefug

Copy link
Copy Markdown
Contributor Author

@Frenzie ok wasnt sure because aard2 was weird. Looking at aard manifest it should aard2.lookup ?
Anyway OSS-Dict supports send so i updated the PR. Should be good now

@pazos

pazos commented Feb 9, 2025

Copy link
Copy Markdown
Member

@Frenzie ok wasnt sure because aard2 was weird. Looking at aard manifest it should aard2.lookup ? Anyway OSS-Dict supports send so i updated the PR. Should be good now

Nope. The string is between our frontend and our backend. And our backend does:

For send: https://github.com/koreader/android-luajit-launcher/blob/master/app/src/main/java/org/koreader/launcher/extensions/ActivityExtensions.kt#L234-L241

For aard2: https://github.com/koreader/android-luajit-launcher/blob/master/app/src/main/java/org/koreader/launcher/extensions/ActivityExtensions.kt#L43-L49

Both are good as far as we're concerned. Just choose your own poison :)

@pazos pazos linked an issue Feb 9, 2025 that may be closed by this pull request
@pazos

pazos commented Feb 9, 2025

Copy link
Copy Markdown
Member

And we're open to add new intents for your project. For instance: colordict (just below aard2 on the link) is the same intent but handles a extra "flag" that make possible to use the activity as an overlay on top of the current activity (and thus prevents two animations between activities for each query). A feature like that would be amazing in OSS-Dict ;)

@farfromrefug

Copy link
Copy Markdown
Contributor Author

@pazos thanks i understand better now! great idea the overlay! Will look at it in september. So we can add the extra flag when it is done!

@pazos

pazos commented Feb 9, 2025

Copy link
Copy Markdown
Member

@farfromrefug: That's great. Please keep us updated :)

I'm assuming you'll stick with send, right?

@pazos pazos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra trailing space after send

Thanks for your time!

@farfromrefug

Copy link
Copy Markdown
Contributor Author

@pazos yes send is perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FR: add support for OSS-Dict

3 participants