Skip to content

CoverBrowser list mode: fix shortcut icon position#13429

Merged
hius07 merged 3 commits into
koreader:masterfrom
hius07:shortcut-icon
Mar 19, 2025
Merged

CoverBrowser list mode: fix shortcut icon position#13429
hius07 merged 3 commits into
koreader:masterfrom
hius07:shortcut-icon

Conversation

@hius07

@hius07 hius07 commented Mar 17, 2025

Copy link
Copy Markdown
Member

Before

0

1

Mirrored layout, the icon in the right
3

After

2

4


This change is Reviewable

@poire-z poire-z left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trusting you on the maths - and on the big cleanup that looks ok.

@poire-z

poire-z commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

How did you witness that ? Are you finally using the emulator ? Or do you have a Kindle with keys ?

@hius07

hius07 commented Mar 17, 2025

Copy link
Copy Markdown
Member Author

Set to true

is_enable_shortcut = Device:hasKeyboard(),

@hius07

hius07 commented Mar 17, 2025

Copy link
Copy Markdown
Member Author

Trusting you on the maths

Not a big maths, FrameContainer adds bordersize:

return Geom:new{
w = content_size.w + ( self.margin + self.bordersize ) * 2 + self._padding_left + self._padding_right,
h = content_size.h + ( self.margin + self.bordersize ) * 2 + self._padding_top + self._padding_bottom
}

@Commodore64user

Copy link
Copy Markdown
Member

the position on grid mode is also a bit weird. of course there is the variability of the book cover heights.

@hius07 hius07 merged commit 5463ab6 into koreader:master Mar 19, 2025
@hius07 hius07 deleted the shortcut-icon branch March 19, 2025 06:01
@hius07 hius07 added this to the 2025.03 milestone Mar 19, 2025
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants