CoverBrowser list mode: fix shortcut icon position#13429
Merged
Conversation
poire-z
approved these changes
Mar 17, 2025
poire-z
left a comment
Contributor
There was a problem hiding this comment.
Trusting you on the maths - and on the big cleanup that looks ok.
Contributor
|
How did you witness that ? Are you finally using the emulator ? Or do you have a Kindle with keys ? |
Member
Author
|
Set to true koreader/frontend/ui/widget/menu.lua Line 594 in fab3a43 |
Member
Author
Not a big maths, FrameContainer adds bordersize: koreader/frontend/ui/widget/container/framecontainer.lua Lines 62 to 65 in fab3a43 |
Member
|
the position on grid mode is also a bit weird. of course there is the variability of the book cover heights. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
Mirrored layout, the icon in the right

After
This change is