File browser: filter by status

[hius07]

---

This change is 

[hius07]

Usage hint: long-pressing on the "Book status: ..." menu item resets the filter to "all".

"All" does not check (and fetch) book statuses.
Reminder: book statuses are cached in the BookList module.

[poire-z]

(Not a user of this feature, no strong opinion, just a little feeling that showing some status or some others is more of a one-shot decision for the current browsing session, than a full sticky filebrowser setting, so more something I would expect from the plus menu. But in History, we have it in the hamburger menu, and it sticks. Also probably more complicated to do it from elsewhere than just replacing show_finished.)

[hius07]

I thought about the Plus menu.
(1) +5 new buttons, overloaded popup dialog
(2) no way to have a combined filter, like "reading" + "on hold"
(3) the same number of gestures to reset the filter: (tap on the Plus icon + tap on the All button) vs (call the upper menu + long-press on the Book status item)
(4) duplicated "Show finished" menu item (actually, sticky filter by status)
(5) more lines of code

[hius07]

In History and Collections the popup dialog is the only way to call actions (I thought about the upper touch menu, looks rather complicated).
In History filter by status sticks (there was a request for that), in Collections doesn't.

[Commodore64user]

Although this partially solves #13507 (currently only fixing FM but not reader), shouldn’t this be fixing the fact that random things are being passed as arguments instead?

[hius07]

Agree, let's discuss and fix it separately.