Screensaver: improve sleep screen message

[hius07]

(1) Because of long description, the input dialog buttons were overlapped with the keyboard.
Move description to the info message.
(2) Allow multiline messages. Closes #13559.

---

This change is 

[Commodore64user]

Have a look at the infomessage class so that you avoid running through the force_one_line loop (when the message is in the middle only)

https://github.com/koreader/koreader/blob/master/frontend/ui/widget/infomessage.lua#L182

[hius07]

If you want one line, don't press Enter.

[Commodore64user]

If you want one line, don't press Enter.

What i mean is, you might be unnecessarily running through the whole loop every time you lock the device, but you don't need to, as you would expect to not be a single line

[hius07]

The "whole loop" of what?

[Commodore64user]

https://github.com/koreader/koreader/blob/master/frontend/ui/widget/infomessage.lua#L196-L220

[hius07]

Yes, we reduce font size of long messages to fit to the screen.

[Commodore64user]

You are doing it as well with the middle sleep screen message, that's what i am trying to tell you... avoid running the loop if you have multiple lines as it goes against force_one_line #13026 and #13337

[hius07]

avoid running the loop if you have multiple lines

But I need to fit to the screen, even with multiple lines.

koreader/frontend/ui/widget/infomessage.lua

Line 187 in bf8adf2

max_height = Screen:getHeight() * 0.95

force_one_line is not applicable if I pressed Enter.

[Commodore64user]

Just saying make sure you don't end up here

https://github.com/koreader/koreader/blob/master/frontend/ui/widget/infomessage.lua#L182

[hius07]

Sorry for my bad English, I don't understand you.
What changes do you propose to make to this PR?
(Note that multi lines sleep screen message is not a new feature)

[Commodore64user]

Force-one-line is true for the middle message, but a multi line goes against that… so you are unnecessarily running the loop that reduces the font size to fit the text in one line, even though it will end up not being a single line… ever, my suggestion is that you don’t set max-height to that of force-one-line, i.e enter the else instead

koreader/frontend/ui/screensaver.lua

Lines 692 to 698 in bf8adf2

	if message_pos == "middle" then
	message_widget = InfoMessage:new{
	text = screensaver_message,
	readonly = true,
	dismissable = false,
	force_one_line = true,
	}

Does that make sense?

[mergen3107]

Sorry guys, a side question.
Any chance of getting all this text on lock screen justified?

[hius07]

unnecessarily running the loop that reduces the font size to fit the text in one line

The loop is required to fit the text in the max height.
For middle position and no "break-line" chars in the text, the max height is, roughly, a line height.
Otherwise, max height is, roughly, a screen height.
The loop is required in any case.

If the text contains "line-break" chars, force_one_line is not applicable:

koreader/frontend/ui/widget/infomessage.lua

Line 182 in bf8adf2

if self.force_one_line and not self.text:find("\n") then

[hius07]

Any chance of getting all this text on lock screen justified?

Yes. What does your long text contain?

[mergen3107]

Yes. What does your long text contain?

@hius07
Sorry, I totally confused terms.

I wanted to ask about centered text instead of justified.

On the screensaver screenshot in the OP, is it possible to have the text in each line centered?

[hius07]

is it possible to have the text in each line centered?

The lines are centered when the message position is "top" or "bottom".

[mergen3107]

But for vertically centered position horizontal position is not available? :D

Seems weird, but OK

[Commodore64user]

When I say avoid the loop, what i mean is avoid running it under force_one_line. I am NOT saying you should not keep the 95% thing. If the break line meets the not self.text:find("\n") great. That is what i have been trying to say. Make sure that you don't enter this case.