Skip to content

add hall file for PW6 - #13615

Merged
NiLuJe merged 1 commit into
koreader:masterfrom
mergen3107:pw6-hall-effect
Apr 18, 2025
Merged

add hall file for PW6#13615
NiLuJe merged 1 commit into
koreader:masterfrom
mergen3107:pw6-hall-effect

Conversation

@mergen3107

@mergen3107 mergen3107 commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

Identical to #13603 but for PW6. Tested on mine.

P.S. as a side note, this setting persists even after exiting from KOReader (which works great for me!).
@NiLuJe


This change is Reviewable

@Frenzie Frenzie added this to the 2025.05 milestone Apr 17, 2025
@Frenzie Frenzie added the Kindle label Apr 17, 2025
@Commodore64user

Commodore64user commented Apr 17, 2025

Copy link
Copy Markdown
Member

why not extend and "guess" that the basic 4 also uses the same? the warmth_intensity_file was guesstimated and given the lack of @mergen3107's issues ;) correct.

@Frenzie

Frenzie commented Apr 17, 2025

Copy link
Copy Markdown
Member

Poser la question, c'est y répondre.

@Commodore64user

Copy link
Copy Markdown
Member

Mr. fancy over here speaking in French now :)

@mergen3107

Copy link
Copy Markdown
Contributor Author

I don't wanna guess and let them defend for themselves :D I only commit things I can test

@NiLuJe

NiLuJe commented Apr 17, 2025

Copy link
Copy Markdown
Member

I'm also not sure if the hall thingy isn't in the "if we pass the wrong path, we just crash" basket, which would be bad ;).

@Commodore64user

Copy link
Copy Markdown
Member

Pfff, is actually good to get a crash every now and then... gets all the bad stuff out the system ;)

@mergen3107

Copy link
Copy Markdown
Contributor Author

Reminds of medieval "cure" to all sickness by bleeding the blood :D

@Commodore64user

Copy link
Copy Markdown
Member

what do you mean medieval?

Screenshot 2025-04-17 at 22 22 13

@mergen3107

Copy link
Copy Markdown
Contributor Author

Can someone please merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants