Skip to content

Fulltext search: start page - #13798

Merged
hius07 merged 4 commits into
koreader:masterfrom
hius07:fulltext-search-start-page
May 22, 2025
Merged

hius07 merged 4 commits into
koreader:masterfrom
hius07:fulltext-search-start-page

Conversation

@hius07

@hius07 hius07 commented May 16, 2025

Copy link
Copy Markdown
Member

Easy jump to the page which the search started on.
Helps in #13779, allowing to browse through all search results without jumping back every time.
Also an action, can be added to a profile.

1


This change is Reviewable

{
text_func = function()
local pn = self.ui.rolling and self.ui.document:getPageFromXPointer(self.start_page) or self.start_page
return T(_("Go to search start page: %1"), self.ui.annotation:getPageRef(self.start_page, pn) or pn)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit awkward, perhaps "Return to the original search page" or "Return to where the search began"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with something like Go back to search start or Return where search began.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the word "page" is needed since the page number is displayed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, fine by me.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sentence makes no sense, with all due respect.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It means there's a mystery number there otherwise.

Unless you're of the opinion it's better without stating the number, but that'd also be rather mysterious (as in, where am I right now in relation to that page, etc.)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go back (Page %1) or Jump back (Page %1)?

The user does know that the search is currently in progress, so "go back" naturally means "go back before this process started". Simple and effective :D

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am of the opinion that number or no number, it should be a properly constructed sentence. The actual number is of little relevance though, so happy to do without it, but not bothered if included.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, during the search knowing the page where you started is handy. Like, is the content you found 10 pages forward? 100? or in the opposite direction?

It is like an anchor

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go back (Page %1) or Jump back (Page %1)?

To fit in with what's right above that'd be Go back to page: %1, but yes.

@hius07
hius07 merged commit 905ee56 into koreader:master May 22, 2025
@hius07
hius07 deleted the fulltext-search-start-page branch May 22, 2025 14:58
@hius07 hius07 added this to the 2025.05 milestone May 22, 2025
Commodore64user pushed a commit to Commodore64user/KOReader_fork that referenced this pull request May 23, 2025
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants