tools/mkrelease: fix bug in AWK helpers - #13847
Merged
Frenzie merged 1 commit intoMay 23, 2025
Merged
Conversation
The manifest entry for `koreader/frontend/socketutil.lua` is wrong: ``` koreader/frontend/socketutil.lua/ ``` That's because the CRC for that file (0E376639) compare as a false value when used conditionally with `if (0E376639)`. The correct way to check for an empty string is to use: `if (0E376639 != "")`. NOTE: no impact that I could see on the actual generated archive, e.g. for kindlepw2: the file is still included.
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
The manifest entry for `koreader/frontend/socketutil.lua` is wrong: ``` koreader/frontend/socketutil.lua/ ``` That's because the CRC for that file (0E376639) compare as a false value when used conditionally with `if (0E376639)`. The correct way to check for an empty string is to use: `if (0E376639 != "")`. NOTE: no impact that I could see on the actual generated archive, e.g. for kindlepw2: the file is still included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manifest entry for
koreader/frontend/socketutil.luais wrong:That's because the CRC for that file (0E376639) compare as a false value when used conditionally with
if (0E376639). The correct way to check for an empty string is to use:if (0E376639 != "").NOTE: no impact that I could see on the actual generated archive, e.g.
for kindlepw2: the file is still included.
This change is