Skip to content

ReadTimer + Profiles auto-exec - #14309

Merged
Frenzie merged 6 commits into
koreader:masterfrom
hius07:readtimer-profiles
Sep 14, 2025
Merged

Frenzie merged 6 commits into
koreader:masterfrom
hius07:readtimer-profiles

Conversation

@hius07

@hius07 hius07 commented Sep 12, 2025

Copy link
Copy Markdown
Member
  1. New event "ReadTimerExpired" broadcasted by ReadTimer and handled by Profiles auto-exec.
    Usual restriction: profile auto-exec requires reader or file browser without any upper windows/dialogs opened.
1
  1. Because of (1), a user may not need a message on timer expiry. Add a setting. Usual message/confirmbox by default.
2 3
  1. Add a setting to auto-reschedule timer interval.
4
  1. Minor ReadTimer wordings unification.
  2. Move all ReadTimer settings to a single table.

This change is Reviewable

@hius07 hius07 added the Plugin label Sep 12, 2025
Comment thread plugins/readtimer.koplugin/main.lua Outdated
min = curr_min,
ok_text = _("Set alarm"),
title_text = _("New alarm"),
ok_text = _("Start timer"),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change congruent with that other one?

image

@hius07 hius07 Sep 13, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a recent change after heavily testing the new features.
What do we want and what does this SpinWidget do? We want to start the timer, not just set the time/interval.

5

@Frenzie Frenzie Sep 13, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say an alarm is not a timer (even if it acts as an x-minute timer under the hood) and the checkbox is just a side feature.

The interval is a timer though and that's probably a better word to use there.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But also "Stop timer" for both.

Do you recommend to keep "Set alarm" and "Set interval" for spinwidget OK buttons?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember the @offset-torque 's post about the timer and its wordings that they were not perfect.

@Frenzie Frenzie Sep 13, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you recommend to keep "Set alarm" and "Set interval" for spinwidget OK buttons?

"Set alarm" or "Set time" for the alarm, "Start timer" for the interval one.

Edit: but I mean "timer" everywhere, no interval.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still confusing wording in that plugin.
As of 2025.08 version, situation is this:

  • "Set time" button creates a new "alarm" (but it shows a "timer" in the status bar)
  • "Set interval" button sets a "timer"

Why not properly name the buttons for things which they will create.
In this case they would be:

  • Set an alarm
  • Set a timer

Also wording in the "New Alarm" dialog should match the thing we are creating. So instead of "Show timer in status bar" it should be "Show alarm in the status bar" to be consistent and not confusing.

Visualization of the proposed changes:

koreader_read_timer

Should I move this to an issue or good here?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay here, for the next round of changes.
Now (in the nightly build) the main menu items are: Set alarm, Set interval.
I noticed to change the latter to Set timer.

In the footer, we actually show the countdown timer in both cases.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the footer, we actually show the countdown timer in both cases.

I just checked and status bar shows either the "alarm countdown" or the "timer countdown".

Think as a new user:

I want to set an alarm. I clicked the "Set alarm" button. I didn't click the "Set timer" button. Why am I seeing "Show timer in status bar"?!? I should see a countdown to my alarm that I am currently setting.

Which is what that checkboxes do actually. Just named incorrectly now.

"Set timer" dialog's checkboxes are (nearly) correct because they show the countdown to the "timer" which is set in that dialog.

Clearer and more accurate wording for them is:

  • "Show countdown to alarm in status bar"
  • "Show countdown to timer in status bar"

But it is more crowded.

@Frenzie Frenzie added this to the 2025.10 milestone Sep 13, 2025
@Frenzie
Frenzie merged commit 99c7d00 into koreader:master Sep 14, 2025
5 of 6 checks passed
@hius07
hius07 deleted the readtimer-profiles branch September 14, 2025 15:43
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants