Add separator to custom footer text item - #14328
Conversation
|
I'm not sure about this. |
|
I did do that with a cut and paste, but it was hard to find the right symbol and paste it on a Kobo. I did it in a desktop application and then manually updated the settings file on the Kobo. Thought it would be easier this way. |
|
Also I believe (but haven't tried) that changing the separator in settings will update this automatically |
Correct. It is indeed a type of variable in that sense. |
|
I still don't feel the settings to be variables. Anyway, up to @Frenzie. If approved, this pattern should be under UPD: not under |
| end | ||
|
|
||
| if patterns["%r"] then | ||
| local separator_icon = self.ui.view.footer:genSeparator() |
There was a problem hiding this comment.
Depending on the settings it can be not an icon, so just separator.
There was a problem hiding this comment.
UPD: no need of this local at all.
There was a problem hiding this comment.
Local removed
|
|
||
| if patterns["%r"] then | ||
| local separator_icon = self.ui.view.footer:genSeparator() | ||
| if separator_icon then |
There was a problem hiding this comment.
genSeparator always returns something, the check is not needed.
There was a problem hiding this comment.
Check removed
I think it makes sense to have your added separators automatically change along with any built-in ones. |
|
I set my separator to all the choices (vertical bar/bullet/dot/no separator) and noticed that the separator changed each time and did not crash when "no separator" was chosen |
This change is