Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
HTML dictionary link support #3603
I just tested it, and I think the
Note that the hold on word callback does (with lookup_target="LookupWord")
so it calls ReaderDictionary:onLookupWord() without the 3rd highlight argument, which then sets self.highlight to nil.
So, I guess it's fine to do that also where you initially did it (sorry for the invitation to remove it :| )
It should be good to merge after that.
As a side note about MuPDF:
It's removed in DictQuickLookup:onClose and in DictQuickLookup:onHoldClose.
No problem. :) It's quite tricky that only the first dicitonary window stores the highlight.