New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update History and Last open document when move (cut and paste) file #3607

Merged
merged 2 commits into from Jan 16, 2018

Conversation

Projects
None yet
2 participants
@robert00s
Contributor

robert00s commented Jan 15, 2018

No description provided.

@@ -545,6 +545,13 @@ function FileManager:pasteHere(file)
self:moveFile(DocSettings:getSidecarDir(orig), dest) -- dest is always a directory
end
if self:moveFile(orig, dest) then
--update history
local dest_file = dest .."/" .. util.basename(orig)

This comment has been minimized.

@Frenzie

Frenzie Jan 15, 2018

Member

Could you use string.format instead of string concat? :-)

@Frenzie Frenzie merged commit a66d657 into koreader:master Jan 16, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@Frenzie

This comment has been minimized.

Member

Frenzie commented Jan 16, 2018

Thanks!

@robert00s robert00s deleted the robert00s:cut_history branch Jan 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment