New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add menu item for toggling auto_book_status #3642

Merged
merged 1 commit into from Jan 30, 2018

Conversation

Projects
None yet
2 participants
@poire-z
Contributor

poire-z commented Jan 30, 2018

See #3638 (comment) (and #2363, #2366). Closes #3638.
Any suggestion for a better "Save document (write highlights into PDF)" ?
I understand the setting and menu title was made for a generic save any stuff that make sense for this document format to the document itself, but for now, it only works with PDF, and only for saving highlights into the PDF file. (The generic title Save document does not give any hint about what this could do, and got me perplexed since I first saw it :)

@Frenzie Frenzie added the UX label Jan 30, 2018

@Frenzie

This comment has been minimized.

Member

Frenzie commented Jan 30, 2018

Seems good enough to me. :-)

@Frenzie Frenzie merged commit 9d44930 into koreader:master Jan 30, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:menu_bookstatus branch Jan 30, 2018

@Frenzie

This comment has been minimized.

Member

Frenzie commented Jan 30, 2018

A couple of screenshots for onlookers.

Before

35531674-f563f698-0537-11e8-8e97-a036384b3ca4

After

screenshot_2018-01-30_14-21-13
screenshot_2018-01-30_14-21-22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment