Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
cre: cache re-use fix, warnings and allow cache sizes increase #3700
This should considerably speed up the re-opening of big epub books from their cache.
Full technical details in koreader/crengine#100 (and koreader/koreader-base#601):
I don't know it we should already increase theses size with a default like:
+ G_reader_settings:readSetting("cre_storage_size_factor") or 2.0)
or wait a few nightlys for that.
Just mentionning bellow the new warnings that could be seen in crash.log here (so users searching issues would find this post).
KOReader and its epub rendering engine (crengine) may work very well in spite of these warnings.
To increase the cache size, add to your
This one about ELEMENTS' STYLE DATA would probably cause this other warning when re-opening a book from cache:
and it means the cache can't be re-used, and re-opening an already opened book would take a long time.
This one about TEXT NODES may be the reason for rendering problems (we've seen table rendering problems in #3623).
No bug yet seen when this one about RENDERED RECTS is reached. May be a slight slow done in page turning speed, that gets better when we increase sizes till we make this warning disappear.
No bug yet seen when this one about ELEMENTS is reached
Mar 1, 2018
1 check passed
This was referenced
Mar 6, 2018
@Frenzie : before you release anything, we'll have to decide and add a default for
I initially thought 4 would be enough, @Eduardomb22 has been using 10, and I've been using 20 - without any side effects, and memory going from 100 to 120 Mb with my biggest book).
So, I'd say we could use a big number, like