New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues with movable dict window (reworked) #3726

Merged
merged 1 commit into from Mar 7, 2018

Conversation

Projects
None yet
2 participants
@poire-z
Contributor

poire-z commented Mar 6, 2018

Clearer rework of #3722 : simpler, more explicite, no need for the additional callback. The Pan and PanRelease don't happen while Hold, so no need for checking if selection in progress.
Use https://github.com/koreader/koreader/compare/master~2...poire-z:fix_movable_dict_reworked?expand=1for review
(I had some afterthoughts after it was merged - so let this one sit for a few hours :)

Fix some issues with movable dict window (reworked)
Clearer rework of this fix (a few commits ago): more explicite,
no need for the additional callback.
@poire-z

This comment has been minimized.

Show comment
Hide comment
@poire-z

poire-z Mar 7, 2018

Contributor

No afterthought, so have a quick review please.

Contributor

poire-z commented Mar 7, 2018

No afterthought, so have a quick review please.

@Frenzie

Frenzie approved these changes Mar 7, 2018

Looks cleaner & better, didn't test.

@poire-z poire-z merged commit 48da3dc into koreader:master Mar 7, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:fix_movable_dict_reworked branch Mar 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment