New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cre: more constrast settings #3737

Merged
merged 3 commits into from Mar 11, 2018

Conversation

Projects
None yet
2 participants
@poire-z
Contributor

poire-z commented Mar 11, 2018

Use ButtonProgress like it was done by @robert00s for kopt in #3463.
8 buttons (like for kopt), with gamma indexes:
The 3 firsts are our old 3 settings: 10 15 25
The 4th is what was previously the max index: 30 (so people that increased it to the max can get this value back as is - a small change can be bothering, it did to me when I set it to 35, I wanted my 30 back).
The 4th next values are new darker gamma.
When you select one, it displays (like it does for pdf) the gamma value (1.45) instead of the index (25) it did previously.
(I let in the initialisation with DCREREADER_CONFIG_DEFAULT_FONT_GAMMA for people that set a different one in their defaults.persistent.lua)

There is still a small issue: when you hold to make it default, it displays the index (25) instead of the gamma value (1.45). Spent one hour trying to fix that in configdialog.lua but I just managed to mess with how it worked well with pdf ... - the args / values stuff thare are used for settings, arguments to the events, and display is a bit confusing. I give up for now. solved lazily by adding a new labels config element

cre: more constrast settings
Use ButtonProgress like it was done for kopt.
DCREREADER_CONFIG_LIGHTER_FONT_GAMMA = 10
DCREREADER_CONFIG_DEFAULT_FONT_GAMMA = 15
DCREREADER_CONFIG_DARKER_FONT_GAMMA = 25
-- crereader font gamma (no more used)

This comment has been minimized.

@Frenzie

Frenzie Mar 11, 2018

Member

So why keep it? :-P

This comment has been minimized.

@poire-z

poire-z Mar 11, 2018

Contributor

Just so people don't someday go there wondering "I'm sure there was a setting for that!, where is it?!". They'll find them commented, and know they are no more used. That's friendly.
You want them removed?

This comment has been minimized.

@Frenzie

Frenzie Mar 11, 2018

Member

Nah, keep it but change it to "no longer used" or "not used anymore"

@poire-z poire-z merged commit c93bbec into koreader:master Mar 11, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:cre_more_gamma branch Mar 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment