New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a keybinding to access the hold-item menu #3765

Merged
merged 6 commits into from Mar 18, 2018

Conversation

Projects
None yet
3 participants
@onde2rock
Contributor

onde2rock commented Mar 16, 2018

Quick edit to be able to open the hold menu on non touch devices.

The naviguation in the hold menu need a bit of getting used to, but it's fully useable.

@poire-z

This comment has been minimized.

Contributor

poire-z commented Mar 17, 2018

Tested on the emulator, and it solves #3745 (comment)
It's a bit different than how it did before, but it allows selecting all the buttons, so it's fine.

Just mentionning the differences (if I remember correctly):
Before, if on the 3rd column, when going down to a line with only 2 buttons, you went to the 2nd button.
With this, you're stuck on the line with 3 buttons, you need to go left to the the 2nd button to be able to go down. But you can still reach them all :)

@onde2rock

This comment has been minimized.

Contributor

onde2rock commented Mar 17, 2018

Yes, the naviguation is a bit weird. I'm starting to run into the limitations of the focusmanager, same with the readermenu.

I don't really see a better way to support complex layout with the focusmanager remaining generic.

I didn't even know this menu existed until recently reading the code, so this was a nice surprise.

@Frenzie

This comment has been minimized.

Member

Frenzie commented Mar 17, 2018

While generally preferable, there's no requirement that it remain generic. Or more concretely, generic FocusManager should stay but if something specific is required you can make a FocusManagerSomeSpecialCase. Of course that'll be eyed with much scrutiny. :-P

@poire-z

This comment has been minimized.

Contributor

poire-z commented Mar 18, 2018

I can merge this if you consider it done, so you can start from fresh with your next PR?

@onde2rock

This comment has been minimized.

Contributor

onde2rock commented Mar 18, 2018

Hum ok, I will try to make fixes to the naviguation weirdness in another PR

@poire-z poire-z merged commit 5fcb804 into koreader:master Mar 18, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@onde2rock onde2rock deleted the onde2rock:holdmenu-keybinding branch Mar 18, 2018

Frenzie added a commit that referenced this pull request Mar 21, 2018

[FocusManager] More intuitive key navigation + spec (#3774)
FocusManager now finds the closest widget on the right or left on inner horizontal border.

See : #3765 (comment)

Frenzie added a commit to Frenzie/koreader-base that referenced this pull request Mar 30, 2018

[feat] SDL2: preliminary gamepad support
This is a "dumb" implementation that spits out fake keyboard events.

* Left trigger & d-pad: arrow keys
* Bumpers and right trigger: page up/down
* Menu button: menu
* A: enter
* B: back

This is sufficient to use most of the program.

Made possible by @onde2rock's recent efforts in koreader/koreader#3796
koreader/koreader#3785 koreader/koreader#3774
koreader/koreader#3765 and koreader/koreader#3745

Frenzie added a commit to koreader/koreader-base that referenced this pull request Mar 31, 2018

[feat] SDL2: preliminary gamepad support (#628)
This is a "dumb" implementation that spits out fake keyboard events.

* Left stick & d-pad: arrow keys
* Bumpers and right stick: page up/down
* Menu button: menu
* A: enter
* B: back

This is sufficient to use most of the program.

Made possible by @onde2rock's recent efforts in koreader/koreader#3796
koreader/koreader#3785 koreader/koreader#3774
koreader/koreader#3765 and koreader/koreader#3745

Frenzie added a commit to Frenzie/koreader that referenced this pull request Mar 31, 2018

[feat, UX] bump base for SDL2: preliminary gamepad support
* [feat] SDL2: preliminary gamepad support koreader/koreader-base#628

This is a "dumb" implementation that spits out fake keyboard events.

* Left stick & d-pad: arrow keys
* Bumpers and right stick: page up/down
* Menu button: menu
* A: enter
* B: back

This is sufficient to use most of the program.

Made possible by @onde2rock's recent efforts in koreader#3796
koreader#3785 koreader#3774
koreader#3765 and koreader#3745

Frenzie added a commit that referenced this pull request Mar 31, 2018

[feat, UX] bump base for SDL2: preliminary gamepad support (#3819)
* [feat] SDL2: preliminary gamepad support koreader/koreader-base#628

This is a "dumb" implementation that spits out fake keyboard events.

* Left stick & d-pad: arrow keys
* Bumpers and right stick: page up/down
* Menu button: menu
* A: enter
* B: back

This is sufficient to use most of the program.

Made possible by @onde2rock's recent efforts in #3796
#3785 #3774
#3765 and #3745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment