New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] SDL2: resize window #3775

Merged
merged 5 commits into from Mar 18, 2018

Conversation

Projects
None yet
2 participants
@Frenzie
Member

Frenzie commented Mar 18, 2018

References #1417

Bumps base for koreader/koreader-base#614

Also includes:

A couple of screenshots:

Just opened

Randomly resized

Maximized

@Frenzie Frenzie requested a review from poire-z Mar 18, 2018

@Frenzie Frenzie added the UX label Mar 18, 2018

@poire-z

Looks fine.
Have a quick test with some epub if you didn't already, just to be sure you don't get back to page 1 (in #3740, i had to hack ReaderRolling:onChangeScreenMode() to temporarily re-enable history - just to confirm it doesn't need any more such hack)

@Frenzie

This comment has been minimized.

Member

Frenzie commented Mar 18, 2018

Something may not be quite right about the page numbering (not in the sense of going back to page 1, but I don't think total numbers change) but I'm not too concerned by the various imperfections. My purpose here is primarily to make it easy to notice the flaws in the first place, partially with an eye to Android. The viewport can change dynamically there, but in some places the behavior is currently not quite right yet. But Android is… suboptimal to play around with.

The basic problem is that most widgets don't do anything with a ScreenResize event. You're okay in ReaderUI and sort of okay-ish in FileManager and that's mostly it.

@Frenzie Frenzie merged commit 24c0132 into koreader:master Mar 18, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:resize branch Mar 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment