Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[feat] SDL2: resize window #3775
Have a quick test with some epub if you didn't already, just to be sure you don't get back to page 1 (in #3740, i had to hack ReaderRolling:onChangeScreenMode() to temporarily re-enable history - just to confirm it doesn't need any more such hack)
Something may not be quite right about the page numbering (not in the sense of going back to page 1, but I don't think total numbers change) but I'm not too concerned by the various imperfections. My purpose here is primarily to make it easy to notice the flaws in the first place, partially with an eye to Android. The viewport can change dynamically there, but in some places the behavior is currently not quite right yet. But Android is… suboptimal to play around with.
The basic problem is that most widgets don't do anything with a ScreenResize event. You're okay in ReaderUI and sort of okay-ish in FileManager and that's mostly it.