New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] apps/reader/modules/readerfooter: also redraw progressbar on height change #3780

Merged
merged 1 commit into from Mar 20, 2018

Conversation

Projects
None yet
2 participants
@Frenzie
Member

Frenzie commented Mar 20, 2018

@poire-z Now this is a big one for Android. I wasn't sure if it was a problem in ReaderUI or in the Android framebuffer stuff. Thanks to resizing the problem was immediately obvious.

@Frenzie Frenzie added the UX label Mar 20, 2018

@poire-z

This comment has been minimized.

Contributor

poire-z commented Mar 20, 2018

Looks fine and obvious.
But I don't even know what was the problem :) My height never changes (it's always full screen).

(The most annoying stuff, if I were really reading on Android, would be than, koreader being fulle screen, when you swipe from bottom to make the bottom menu appear to be able to go home - not exiting - is that this send a swipe up event and cause a page turn - so, I always Exit to keep the page).

@Frenzie

This comment has been minimized.

Member

Frenzie commented Mar 20, 2018

Innocently (as it normally occurs) the problem is this:

screenshot_2018-03-20_21-38-10

There's also this ugly form:

screenshot_2018-03-20_21-38-35

@Frenzie

This comment has been minimized.

Member

Frenzie commented Mar 20, 2018

PS When I say "big one" I'm obviously exaggerating, but it's exactly the kind of real life problem I wanted to tackle without Android. ;-)

@Frenzie Frenzie merged commit 9624264 into koreader:master Mar 20, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:readerfooter branch Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment