New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Make ScrollTextWidget:moveCursor return the new charpos. #3808

Merged
merged 1 commit into from Mar 28, 2018

Conversation

Projects
None yet
2 participants
@edorfaus
Contributor

edorfaus commented Mar 28, 2018

Found by using the InputText widget with scroll=true, and trying to enter text after tapping to move the cursor - wbuilder crashed with the error "./luajit: frontend/ui/widget/inputtext.lua:258: bad argument #2 to 'insert' (number expected, got nil)".

@Frenzie Frenzie merged commit f36d93a into koreader:master Mar 28, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@Frenzie

This comment has been minimized.

Member

Frenzie commented Mar 28, 2018

Thanks!

@Frenzie Frenzie added bug UX labels Mar 28, 2018

@edorfaus edorfaus deleted the edorfaus:bugfix/movecursor-return-in-scrolltextwidget branch Mar 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment