New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoverBrowser: set default display modes on first launch #3834

Merged
merged 1 commit into from Apr 6, 2018

Conversation

Projects
None yet
3 participants
@poire-z
Contributor

poire-z commented Apr 6, 2018

As requested in #3817 (comment) :

I'd definitely prefer defaulting to one of the detailed list views these days. Probably either detailed list with cover images and metadata or detailed list with cover images and filenames.

I tried cover images and filenames, which would be the less intrusive for people used to classic mode, but the bigger filename in bold was a bit strong for me (when compared to Classic mode with small font size). Metadata with title and authors on 2 lines looked nicer.

@KenMaltby : I believe you use classic mode: with this, on your next update, you'll be switched to some other modes, and you'll have to manually reset them to classic mode (and delete Cache DB if you want to keep things tidy). Is that ok ?

@Frenzie

Frenzie approved these changes Apr 6, 2018

Incidentally, these settings are exactly what I use myself.

@KenMaltby

This comment has been minimized.

KenMaltby commented Apr 6, 2018

That sounds good for me, I do use the Classic Mode in the File Browser and the "Detailed with cover images and filenames" for History. I also have the "Append series metadata to title" checked, which works sometimes. My only worry might be for the average user's possible confusion. It looks like your defaults should appeal to most and make a good starting point for the user. I also think that those more concerned with performance and a large library, would be more likely to be those able to find their own optimal solution, among the options you provide. So should work fine, but in any case if it were to become an issue the users will let us know. Personally, I think they will like it.

@Frenzie Frenzie merged commit cc7ef36 into koreader:master Apr 6, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie added the UX label Apr 6, 2018

@poire-z poire-z deleted the poire-z:coverbro_defaults branch Apr 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment