New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the bug where "Press" key does not open config menu on Kindle 4 NT #3898

Merged
merged 1 commit into from Apr 19, 2018

Conversation

Projects
None yet
3 participants
@insraq
Contributor

insraq commented Apr 19, 2018

For Kindle 4NT hasKeyboard = no, therefore cannot open config menu. I change the if condition to check hasKeys.

I've tested on my Kindle 4NT and it works.

@Frenzie

This comment has been minimized.

Member

Frenzie commented Apr 19, 2018

Pinging @onde2rock

@Frenzie Frenzie added the Kindle label Apr 19, 2018

@onde2rock

This comment has been minimized.

Contributor

onde2rock commented Apr 19, 2018

Yes, that was not working, this shoud fix it.
Thanks for the PR.

@Frenzie Frenzie merged commit 7f15b3a into koreader:master Apr 19, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@Frenzie

This comment has been minimized.

Member

Frenzie commented Apr 19, 2018

Thanks @insraq !

@insraq

This comment has been minimized.

Contributor

insraq commented Apr 20, 2018

Thank YOU for merging and for such a great project. It makes my old Kindle 4 NT useful again!

@Frenzie

This comment has been minimized.

Member

Frenzie commented Apr 20, 2018

@onde2rock deserves all the credit for making it usable on the Kindle 4NT. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment