New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML widget in GoodReads review #3929

Merged
merged 1 commit into from May 4, 2018

Conversation

Projects
None yet
3 participants
@robert00s
Contributor

robert00s commented May 4, 2018

After adding generic HTML widget in #3573 now we can show descriptions (review) in GoodReads as HTML.
Before:
image

After:
image

@poire-z

This comment has been minimized.

Contributor

poire-z commented May 4, 2018

Btw, I saw when doing #3905 that goodreads plugin was using Pic.openJPGDocumentFromMem(). Didn't date touching it, but may be you could use a generic function from RenderImage instead, if it can make sense (and if MuPDF is just as good as Pic/JPEG).

@Frenzie

This comment has been minimized.

Member

Frenzie commented May 4, 2018

Do you know if GR is always well-formed XML? Technically the HTML widget is an XHTML widget, so it breaks down on markup that isn't well-formed XML.

@robert00s

This comment has been minimized.

Contributor

robert00s commented May 4, 2018

@poire-z I'll prepare another PR to use RenderImage:renderImageData insteed old Pic.openJPGDocumentFromMem()

@robert00s

This comment has been minimized.

Contributor

robert00s commented May 4, 2018

@Frenzie Detail: https://www.goodreads.com/api/index#book.show
Sample xml here 50.xml.txt
In review widget I use only description field. I'm not sure is always well-formated xml but I think it will look better than before.

@Frenzie Frenzie merged commit 4bf4578 into koreader:master May 4, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@robert00s robert00s deleted the robert00s:goodreads_html branch Aug 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment