New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-order typeset menu #3946

Merged
merged 2 commits into from May 14, 2018

Conversation

Projects
None yet
2 participants
@poire-z
Contributor

poire-z commented May 13, 2018

Re-order typeset menu, to group related things (the Highlights in the middle was bothering me).
Reasoning:

  • Highlighting first (present with both EPUB and PDF), and a bit related to the previous menu about Bookmarks, and not much to what's next.
  • Then, for EPUB: Styles, Fonts, and Hyphenation/Floating punctuation.
    For PDF: Switch zoom mode (main use for this menu)
  • Then, reading aids: Page overlap & Perception expander

Menu for EPUB before:
before_epub

Menu for EPUB after:
after_epub

Menu for PDF before:
before_pdf

Menu for PDF after:
after_pdf

And add symbols for default and fallback to the Hyphenation menu, as it was done recently to the Font menu, and make the dialog text similar to the one updated recently for Fonts:
hyph_hold_dialog

Re-order typeset menu
And add symbols for default and fallback to the Hyphenation
menu, as it was done recently to the Font menu.
@Frenzie

This comment has been minimized.

Member

Frenzie commented May 13, 2018

I don't really like the highlighting on top that much. It feels more like a bottom type option to me.

@poire-z

This comment has been minimized.

Contributor

poire-z commented May 13, 2018

That would give this:
image

image

which I agree looks more logical.
(but putting it at top was preventing pushing Font & Style too much up from where my fingers are used to findind them :)

@poire-z

This comment has been minimized.

Contributor

poire-z commented May 13, 2018

PDF users: separator between Switch zoom mode & Page overlap, or do they feel related?
image

@Frenzie

This comment has been minimized.

Member

Frenzie commented May 13, 2018

I prefer with, I think.

@Frenzie

Looks good to me

@poire-z poire-z merged commit 9e4cb59 into koreader:master May 14, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:page_menu branch May 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment