New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts submodule and shallow clone #3951

Merged
merged 2 commits into from May 15, 2018

Conversation

Projects
None yet
3 participants
@Frenzie
Member

Frenzie commented May 15, 2018

As promised in #3942 (comment)

See individual commits for details.

@Frenzie Frenzie changed the title from Fonts to Fonts submodule and shallow clone May 15, 2018

@Frenzie

This comment has been minimized.

Member

Frenzie commented May 15, 2018

@NiLuJe @poire-z We can rebase & merge these commits if you think it's good this way.

@poire-z

This comment has been minimized.

Contributor

poire-z commented May 15, 2018

I have no real experience with submodules, so I totally trust you did it the good way :)

@NiLuJe

This comment has been minimized.

Member

NiLuJe commented May 15, 2018

LGTM!

(I'm following a completely unrelated rabbit hole at the moment, but I'll get back to this ASAP, thanks! ;)).

@Frenzie Frenzie merged commit 32cb1a8 into koreader:master May 15, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:fonts branch May 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment