New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A round of Kindle fixes #3955

Merged
merged 9 commits into from May 16, 2018

Conversation

Projects
None yet
3 participants
@NiLuJe
Member

NiLuJe commented May 16, 2018

Resync the model detection everywhere

Fix a bit of insanity in the screensavers handling.
Fix #2848
Fix #3220 (this one's more of a 'cantfix', but, still).

NiLuJe added some commits May 16, 2018

Pickup current OTA packages
We stopped shipping files w/ the full .tar.gz extension a looooong time
ago.
Kindle screensaver handling experiment
WIP, because there's a fair bit of insanity left in there.
Namely, USBMS is anathema. We simply shouldn't do that, at all,
but the system allows us to do it and basically shoot ourselves in the
head one way or another.
Okay, that should be much saner...
Since the whole deal w/ letting the WM handle stuff was for SO, restrict
that to SO devices.
The other concern was USBMS, but we can't support it.
@NiLuJe

This comment has been minimized.

Member

NiLuJe commented May 16, 2018

Updated the WiKi accordingly ;).

@NiLuJe

This comment has been minimized.

Member

NiLuJe commented May 16, 2018

Note that I only have a vague clue as to what went through my head when I originally implemented said bit of insanity with awesome.

Most likely SO, which was a valid concern. As well as screensavers, which might already not have been at the time if we were already handling screensavers ourselves.
And I definitely think I had USBMS at the back of my mind, which was obviously terribly stupid.

@NiLuJe

This comment has been minimized.

Member

NiLuJe commented May 16, 2018

I don't have access to my SO device anymore, so I had to fake it to test the SO branch.
I correctly get native screensavers, so, yay.
No idea if that won't blow up on actual SO devices because of the added swipe needed.

@Frenzie

Can't judge but nothing that looks bad :p

@NiLuJe

This comment has been minimized.

Member

NiLuJe commented May 16, 2018

I'm seeing my brother tomorrow, so I may get my hands on my old SO PW1, if he even remembers where he could have put it :D.

@NiLuJe NiLuJe merged commit 68c1246 into koreader:master May 16, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@onde2rock

This comment has been minimized.

Contributor

onde2rock commented May 17, 2018

Nice!

I'm curious about cf45ac0
I have been trying to implement USBMS, and it's actually not that hard, if we can guarantee there will be no write on /mnt/us from koreader.

I have been trying two thing :

  • Trying to remount /mnt/us readonly but can't because fuse can't
  • Maybe freezing koreader entirely, be then how to start it up again ?

What bothering me is that the previous soft I was using ( duokan) live on /mnt/us and USBMS work well, so this must be possible.

Anyway, that's why I added ssh, because USBMS does not work...

@NiLuJe

This comment has been minimized.

Member

NiLuJe commented May 17, 2018

NiLuJe added a commit to NiLuJe/koreader that referenced this pull request May 17, 2018

NiLuJe added a commit that referenced this pull request May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment