New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump crengine: LI and CITE fixes are now the defaults #3976

Merged
merged 2 commits into from May 24, 2018

Conversation

Projects
None yet
2 participants
@poire-z
Contributor

poire-z commented May 24, 2018

Books previously opened (that have a metadata.lua, whether with highlights or not, but because they all have a last_xpointer that points to the current page, that can be broken too by the changes)
will continue to have the old wrong behaviour, so they won't be impacted by the breaking changes.
Update cre_dom_version code to use the new functions from cre.cpp.
Remove these Workarounds from Style tweaks.

See #3940 (comment) and previous discussion for context.
Will need a base and crengine bump for:

Users that would really want the old list item behaviour on new books (why would they?!) can add a User style tweak with li {display: -cr-list-item-final; }

bump crengine: LI and CITE fixes are now the defaults
Books previously opened (that have a metadata.lua, whether with
highlights or not, but because they all have a last_xpointer that
points to the current page, that can be broken too by the changes)
will continue to have the old wrong behaviour, so they won't be
impacted by the breaking changes.
Update cre_dom_version code to use the new functions from cre.cpp.
Remove these Workarounds from Style tweaks.
@Frenzie

hooray! :-)

@poire-z poire-z merged commit b498d87 into koreader:master May 24, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:dom_version_new_li_cite branch May 24, 2018

This was referenced May 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment