New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextEditor: allow scrolling by lines with Pan #4145

Merged
merged 2 commits into from Aug 10, 2018

Conversation

Projects
None yet
1 participant
@poire-z
Contributor

poire-z commented Aug 8, 2018

Feature of ScrollTextWidget, only used for now by TextEditor.
Pan is like Swipe, but wait a bit at end of gesture to release: the line on which Pan was started will be moved to where Pan is released.

May conflict with MovableContainer (so not enabled for DictQuickLookup, where it could have been nice - but it would work only with text dictionaries, not with HTML ones, as ScrollHtmlWidget can't really do that).

Useful to make a whole block of text contained into view, and not be limited by rigid page by page scrolling (eg: to move the function Widget:name() at top of screen and have a wider view of it while you wonder wtf that function does :)

poire-z added some commits Aug 8, 2018

TextEditor: allow scrolling by lines with Pan
Feature of ScrollTextWidget, only used for now by TextEditor.
Pan is like Swipe, but wait a bit at end of gesture to release:
the line on which Pan was started will be moved to where Pan is
released.

May conflict with MovableContainer (so not enabled for DictQuickLookup,
where it could have been nice - but it would work only with text
dictionaries, not with HTML ones, as ScrollHtmlWidget can't really
do that).

@poire-z poire-z merged commit adceda1 into koreader:master Aug 10, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:scroll_by_pan branch Aug 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment