New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Move 'Links' submenu to settings #4204

Merged
merged 1 commit into from Sep 21, 2018

Conversation

Projects
None yet
2 participants
@Frenzie
Member

Frenzie commented Sep 8, 2018

Fixes #4200

@Frenzie Frenzie added the UX label Sep 8, 2018

@poire-z

This comment has been minimized.

Contributor

poire-z commented Sep 8, 2018

Or in the Document> submenu? (That would be burrying a classic menu item quite far down and people could have a hard time finding it, but it's stuff that happens only when reading a document, and it could avoid this Gear menu to span more than one page.)

@Frenzie

This comment has been minimized.

Member

Frenzie commented Sep 8, 2018

That doesn't seem to make much sense when there's also a navigation menu, except in the sense that navigation could go under document.

But document seems to have an end of document action that's really more navigation related. Some illogic seems to have snuck into these menu items in general.

@@ -45,7 +44,9 @@ local order = {
"screen",
"screensaver",
"document",
"----------------------------",

This comment has been minimized.

@poire-z

poire-z Sep 12, 2018

Contributor

Can we move that separator just above, between screensaver and document?
navigation would appear only on devices with keys, and we would get a section with document > end of document action and follow links >, which feels a bit more related to each other than to screensaver and language.

This comment has been minimized.

@Frenzie

Frenzie Sep 13, 2018

Member

Sure, I'll do that.

@Frenzie Frenzie force-pushed the Frenzie:links-settings branch from 08b2f7c to e046719 Sep 20, 2018

@poire-z poire-z merged commit a037fc6 into koreader:master Sep 21, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment