New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Statistics] Add estimate end of read #4241

Merged
merged 3 commits into from Sep 29, 2018

Conversation

Projects
None yet
2 participants
@robert00s
Contributor

robert00s commented Sep 23, 2018

Two new statistics in Current book:

  • Estimate end of read
  • Average time per day

marsjanin - koreader_178

@robert00s robert00s changed the title from Statistics estimate to [Statistics] Add estimate end of read Sep 23, 2018

@@ -977,6 +980,8 @@ function ReaderStatistics:getCurrentStat(id_book)
{ _("Read pages/Total pages"), total_read_pages .. "/" .. self.data.pages },
-- adding 0.5 rounds to nearest integer with math.floor
{ _("Percentage completed"), math.floor(total_read_pages / self.data.pages * 100 + 0.5) .. "%" },
{ _("Average time per day"), util.secondsToClock(total_time_book/tonumber(total_days)), false },
{ _("Estimate end of read"), string.format("%s (%d day(s))", estimate_end_of_read_date, estimate_days_to_read) },

This comment has been minimized.

@Frenzie

Frenzie Sep 23, 2018

Member

Estimated reading finished (date)?

This comment has been minimized.

@robert00s

robert00s Sep 24, 2018

Contributor

That sounds much better.

@Frenzie Frenzie added the enhancement label Sep 29, 2018

@Frenzie Frenzie merged commit 3d128b5 into koreader:master Sep 29, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@Frenzie

This comment has been minimized.

Member

Frenzie commented Sep 29, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment