New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OPDS authentication #4248

Merged
merged 3 commits into from Sep 29, 2018

Conversation

Projects
None yet
2 participants
@robert00s
Contributor

robert00s commented Sep 29, 2018

Close: #4076
Add new optional fields (username and password) to OPDS catalog and local calibre catalog.

test - koreader_179
test - koreader_180

@Frenzie

lgtm but I didn't check in detail nor try it out

@@ -680,7 +652,6 @@ function OPDSBrowser:editOPDSServer(item)
end
function OPDSBrowser:deleteOPDSServer(item)
logger.dbg("delete", item)

This comment has been minimized.

@Frenzie

Frenzie Sep 29, 2018

Member

Wouldn't this be useful to keep around?

@Frenzie Frenzie merged commit 9fda983 into koreader:master Sep 29, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@Frenzie

This comment has been minimized.

Member

Frenzie commented Sep 29, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment