New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key navigation] The back key can be used to go to the parent folder. #4264

Merged
merged 2 commits into from Oct 10, 2018

Conversation

Projects
None yet
2 participants
@onde2rock
Contributor

onde2rock commented Oct 10, 2018

The menu to select this behavior is under "Gear" > "Navigation"
It default to the current behavior named "default"

onde2rock and others added some commits Oct 10, 2018

[Key navigation] The back key can be used to go to the parent folder.
The menu to select this behavior is under "gear">"Navigation"
It default to the current behavior named "default"
return true
end
elseif back_in_filemanager == "parent_folder" then
self:changeToPath(string.format("%s/..", self.path))

This comment has been minimized.

@Frenzie

Frenzie Oct 10, 2018

Member

As an aside, since a recent(ish) LuaJIT upgrade regular concatenation with .. is also JIT-compiled so there's no objective reason to prefer string.format anymore.

@Frenzie Frenzie merged commit 4d424cd into koreader:master Oct 10, 2018

1 check was pending

ci/circleci CircleCI is running your tests
Details

@Frenzie Frenzie added the UX label Oct 10, 2018

@onde2rock onde2rock deleted the onde2rock:better_back_filemanager branch Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment