New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump cre: allow non-word chars in text selection #4267

Merged
merged 1 commit into from Oct 11, 2018

Conversation

Projects
None yet
3 participants
@poire-z
Contributor

poire-z commented Oct 11, 2018

By starting or ending text selection on a punctuation char, a quote or a paren..., these will now be included in the text selection and the higlighted text. Details and screenshots in #4134 (comment). Closes #4134.

bump crengine, which includes:

bump cre: allow non-word chars in text selection
By starting or ending text selection on a punctuation char,
a quote or a paren..., these will now be included in the text
selection and the higlighted text.

bump crengine, which includes:
- Avoid wrap on a space before or after some specific chars

@poire-z poire-z merged commit 76a3d20 into koreader:master Oct 11, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:bump_cre branch Oct 11, 2018

@ptrm

This comment has been minimized.

ptrm commented Oct 15, 2018

This is so much what I wished to happen :D

The only thing that would make me even happier is an option to snap highlight to include punctuation at the end of words (like dots) - so on smaller fonts it would be easier to highlight the period marking the end of sentence inside a paragraph.

@poire-z

This comment has been minimized.

Contributor

poire-z commented Oct 16, 2018

snap highlight to include punctuation at the end of words (like dots)

That would be good if you are used to highlight sentences. But when you highlight just a few words, at end of a sentence (some expression, some person name to lookup later), you would not want that last dot.
So, dot. But no sense with commas/virgules :) so that's not all punctuations.
(And a dot would mess with dict lookup, so we'd need to remove it in that dict lookup code - I fixed text selection to not include punctuation at all 1 year ago, to get rid of that dict lookup filtering.)
Quite not obvious...

So, easier to read your fingers than read your mind :)
(I don't highlight much, but I see it's difficult to include the dot with a small font.)

@poire-z

This comment has been minimized.

Contributor

poire-z commented Oct 16, 2018

Just stumbed on #975: we could add buttons to push the selection one char left of right, one set for start, one set for end. In the "easier to read your fingers" spirit :)

@Frenzie

This comment has been minimized.

Member

Frenzie commented Oct 17, 2018

I believe the suggestion there might be taken from Nickel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment