New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump crengine: fix vertical-align and others #4307

Merged
merged 1 commit into from Nov 4, 2018

Conversation

Projects
None yet
2 participants
@poire-z
Contributor

poire-z commented Nov 4, 2018

bump crengine, which includes:

  • Avoid uneeded re-rendering on load when with full status bar koreader/crengine#238
  • Update french hyphenation pattern koreader/crengine#239
  • koreader/crengine#240 koreader/koreader-base#751 :
    • Fix border-collapse on table cells in some cases
    • Fix line-height inheritance when no unit
    • Fix: don't ignore space following an image
    • Fix: ignore occasional space at start of line
    • Fix possible segfault when viewing HTML
    • Fix and extend support of vertical-align

Also includes:

Also add a style tweak to middle align images with text, which may make some text with inline icons and such nicer than with the default vertical-align: baseline (depending on images sizes and selected Zoom/DPI).
For example in Wikipedia EPUBs (not sure yet if we should explicitely add a vertical-align: middle to inline images when saving as EPUB)

bump crengine: fix vertical-align and others
bump crengine, which includes:
- Avoid uneeded re-rendering on load when with full status bar
- Update french hyphenation pattern
- Fix border-collapse on table cells in some cases
- Fix line-height inheritance when no unit
- Fix: don't ignore space following an image
- Fix: ignore occasional space at start of line
- Fix possible segfault when viewing HTML
- Fix and extend support of vertical-align

Also add a style tweak to middle align images with text, which
may make some text with inline icons and such nicer (depending
on images sizes and selected Zoom/DPI).

@poire-z poire-z merged commit 26aeb61 into koreader:master Nov 4, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:bump_crengine branch Nov 4, 2018

@@ -185,6 +185,11 @@ img {
}
]],
},
{
id = "image_valign_middle";
title = _("Middle align images with text"),

This comment has been minimized.

@Frenzie

Frenzie Nov 17, 2018

Member

The natural way of saying this would be Vertically center images with text or Vertically center align images with text (line). I suspect they chose "middle" in CSS mainly to avoid confusion with horizontal centering. I only suspected what this might even mean because I know CSS.

Vertically middle align images with text would do the trick as well, although I think that middle verges toward CSS jargon if not plain ungrammaticality.

For support, here's the relevant dialog from Word:

2018-11-17 08_47_34-layout vertical alignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment