New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few edge cases crashes and issues #4334

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
3 participants
@poire-z
Contributor

poire-z commented Nov 12, 2018

  • ReaderConfig does not need to call again self:initGesListener() on screen rotation/resize, as it uses the TouchZone infrastructure that deals itself with rotation. So, it was adding new same gestures that were overriding tap on footer and preventing it from working. See #4332 (comment). Closes #4332.
  • ReaderFooter: fix refresh area (which was too small when toggling from hidden to visible)
  • ReaderToc: fix crash when showing TOC in scroll mode after rotation. See #4328 (comment)
  • Menu: fix crash when no onReturn defined (could happen when tap on bottom left corner when showing an empty TOC). Closes #4330.
Fix a few edge cases crashes and issues
- ReaderConfig does not need to call again self:initGesListener() on
  screen rotation/resize, as it uses the TouchZone infrastructure
  that deals itself with rotation. So, it was adding new gestures
  that were overriding tap on footer and preventing it from working.
- ReaderFooter: fix refresh area (which was too small when toggling
  from hidden to visible)
- ReaderToc: fix crash when showing TOC in scroll mode after rotation
- Menu: fix crash when no onReturn defined (could happen when tap on
  bottom left corner when showing an empty TOC)
@cramoisi

This comment has been minimized.

Contributor

cramoisi commented Nov 13, 2018

@poire-z wouldn't be good for this #3832 which i wasn't able to reproduce ?

@poire-z

This comment has been minimized.

Contributor

poire-z commented Nov 13, 2018

Yes, looks like the same bug and it would solve it :)
Still not reproduced since then ? I guess it's possible you had the filemanager (or some other Menu-based widget) not closed and covered by the reader, and you taped on a small space between the botom left corner area and the bottom config menu or footer tap area, and it wasn't intercepted by the reader and so caught by the covered Menu-based widget instance.

@poire-z poire-z merged commit f8199dd into koreader:master Nov 14, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:various_fixes branch Nov 14, 2018

@Frenzie Frenzie added the bug label Nov 17, 2018

@Frenzie

This comment has been minimized.

Member

Frenzie commented Nov 17, 2018

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment