New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallabag fixes and improvements #4347

Merged
merged 4 commits into from Nov 19, 2018

Conversation

Projects
None yet
2 participants
@y-muller
Contributor

y-muller commented Nov 19, 2018

  • Tag not included in request if not set. Fixes #4337
  • Skip failed download rather than stop everything. Fixes #4340
  • Delete leftover file after failed download (ie HTML file with error description in it).
  • Display number of failed files.
  • Check number of articles before proceeding.
  • Skip remote deletion process if disabled.
Show resolved Hide resolved plugins/wallabag.koplugin/main.lua
Show resolved Hide resolved plugins/wallabag.koplugin/main.lua Outdated
if self:download(article) then
downloaded_count = downloaded_count + 1
if articles then
logger.dbg("number of articles: ", articles.total)

This comment has been minimized.

@Frenzie

Frenzie Nov 19, 2018

Member

For clarity and grep it'd probably be a good idea to prefix all or most of these with wallabag.

Frenzie and others added some commits Nov 19, 2018

Info msg rewording
Co-Authored-By: y-muller <yann@darkriver.net>
Yann Muller
[fix] Skip remote deletes if disabled.
Addded Wallabag preffix to logger output.

@Frenzie Frenzie merged commit 3f7f5f0 into koreader:master Nov 19, 2018

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details
@Frenzie

This comment has been minimized.

Member

Frenzie commented Nov 19, 2018

Thanks!

@y-muller y-muller deleted the y-muller:wallabag branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment