New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreDocument: fix document loading interferences #4349

Merged
merged 2 commits into from Nov 20, 2018

Conversation

Projects
None yet
2 participants
@poire-z
Contributor

poire-z commented Nov 19, 2018

When a main document is opened for displaying, some other document openings (for getting metadata or cover image) could affect the main document.
Split some code from CreDocument:init() into another new method CreDocument:setupDefaultView(), that will only be called by ReaderUI when opening the main document (and not by these other openings like Book inforation, View cover...)
Details in #4346 (comment). Closes #4346.
Will need a base bump for koreader/koreader-base#766.

Also speed up some of these other openings (Search, Screensaver) by using doc:loadDocument(false) to load only metadata and avoid parsing the HTML.

poire-z added some commits Nov 19, 2018

CreDocument: fix document loading interferences
When a main document is opened for displaying, some other
document openings (for getting metadata or cover image)
could affect the main document.
Split some code from CreDocument:init() into another new
method CreDocument:setupDefaultView(), that will only be
called by ReaderUI when opening the main document (and not
by these other openings like Book inforation, View cover...)

Also speed up some of these other openings (Search, Screensaver)
by using doc:loadDocument(false) to load only metadata and
avoid parsing the HTML.

@Frenzie Frenzie merged commit 85ac59a into koreader:master Nov 20, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:setupDefaultView branch Nov 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment