New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] MuPDF: set default DPI-based EPUB fontsize #4372

Merged
merged 2 commits into from Dec 2, 2018

Conversation

Projects
None yet
2 participants
@Frenzie
Member

Frenzie commented Dec 2, 2018

Makes an attempt at a reasonable default. References #4368.

[fix] MuPDF: set default DPI-based EPUB fontsize
Makes an attempt at a reasonable default. References #4368.
@poire-z

This comment has been minimized.

Contributor

poire-z commented Dec 2, 2018

We could grab the font size from more candidates, like:

or G_reader_settings:readSetting("copt_font_size")
or DCREREADER_CONFIG_DEFAULT_FONT_SIZE or 22

@Frenzie

This comment has been minimized.

Member

Frenzie commented Dec 2, 2018

I'm not sure if sharing those settings is a good idea, but for the moment I suppose some slightly hackish configurability that isn't overwritten by OTA updates may be better than none.

@poire-z

poire-z approved these changes Dec 2, 2018

@Frenzie Frenzie merged commit 062d9a4 into koreader:master Dec 2, 2018

@Frenzie Frenzie deleted the Frenzie:mupdf-default-epub-fontsize branch Dec 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment