New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong keymapping for Forma #4376

Merged
merged 5 commits into from Dec 7, 2018

Conversation

Projects
None yet
3 participants
@patrick-tang
Copy link
Contributor

patrick-tang commented Dec 5, 2018

Related to #4291.

This is to fix the wrong key mapping.

@patrick-tang patrick-tang referenced this pull request Dec 5, 2018

Closed

Kobo Forma support #4291

@NiLuJe

This comment has been minimized.

Copy link
Member

NiLuJe commented Dec 5, 2018

Most of the nomenclature you used (both in the comments & the filename itself) here is inherited from the Kindle 2/3 and its keyboard, which doesn't really apply here ;).

I'm not necessarily disagreeing with the split to a dedicated map file, although it may be a bit overkill here nonetheless, just nitpicking about the Kindle-specific comment/filename making its way in Kobo-land ;).

@NiLuJe

This comment has been minimized.

Copy link
Member

NiLuJe commented Dec 5, 2018

Other than that, I'll trust you on the inverted button mapping, since I still don't have a Forma ;).

@patrick-tang

This comment has been minimized.

Copy link
Contributor

patrick-tang commented Dec 5, 2018

Most of the nomenclature you used (both in the comments & the filename itself) here is inherited from the Kindle 2/3 and its keyboard, which doesn't really apply here ;).

I'm not necessarily disagreeing with the split to a dedicated map file, although it may be a bit overkill here nonetheless, just nitpicking about the Kindle-specific comment/filename making its way in Kobo-land ;).

Removed the separate map file. Thanks.

@NiLuJe

This comment has been minimized.

Copy link
Member

NiLuJe commented Dec 5, 2018

👍 :)

@poire-z poire-z merged commit a2e7e62 into koreader:master Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment