Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
bump crengine: tables rendering improvements and others #4378
Adds a few style tweaks related to tables (corrections or alternate english wording welcome :)
Enforce table width: 100% in Wikipedia EPUBs to keep previous look, which feels better with the various kinds of tables in Wikipedia pages.
Also includes a fix for diagonal swipe to refresh full screen not working in TOC and History (see #4240 (comment)).
This was referenced
Dec 5, 2018
Oh my, juliet.epub is full of
Do we agree the new is better than the old and worth the 40% raise in pages count?
(I'd rather drop the blockquote style than have to adapt all these unit tests :) ... but well, if I have to...)
An other small thing is that the cover page does and did overflow the page height. But in the page splitting code, a
Now, there is another small thing: I didn't read it in the spec, but Firefox seems to not enforce this strut when there is no text (or no non-space-only text) alongside an image:
<div style="background-color: #ff0000"> <img src="Lac_sevan_armenie.png"> </div>
<div style="background-color: #ff0000; font-size: 400%"> <img src="Lac_sevan_armenie.png"> " </div>
crengine currently enforces it even when there is no text:
Additional note: Firefox does as crengine does when I add at the top of the HTML
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
So, essential question: is it ok/fine/best that crengine now does what Firefox seems to do only when .
It's really by chance I had this HTML "header" in my test file when I did the vertical-align PR...
Checked firefox with various doctypes mentionned in https://www.w3schools.com/tags/tag_doctype.asp.
strut is enforced with
strut is NOT enforced with
(We won't implement different behaviousr based on the doctype in crengine :) we should just have a single most adequate one.)
I agree that the new rendering is more like how one would expect a blockquote to render. Otherwise you'd barely know the difference with a paragraph.
calibre for comparison:
Regarding the strut, you just found out that in between quirks mode and standards mode, there's almost standards mode. ;-)