New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Inform about hold to set custom DPI, up DPI limit to 900 #4388

Merged
merged 1 commit into from Dec 8, 2018

Conversation

Projects
None yet
2 participants
@Frenzie
Copy link
Member

Frenzie commented Dec 8, 2018

  • It was unclear that you needed to hold to set DPI, see #2589 (comment)

  • Up the DPI limit to 900 as several Android devices have already breached 800. This will increase the possibility of crashes due to a higher setting even on relatively high-DPI devices, but that was always already an issue.

  • Also brings the custom DPI dialog box in line with the UX guidelines as per http://koreader.rocks/doc/modules/ui.widget.confirmbox.html.

Before

screenshot_2018-12-08_17-40-53
screenshot_2018-12-08_17-41-05

After

screenshot_2018-12-08_17-40-37
screenshot_2018-12-08_17-44-11

[UX] Inform about hold to set custom DPI, up DPI limit to 900
* It was unclear that you needed to hold to set DPI, see #2589 (comment)

* Up the DPI limit to 900 as several Android devices have already breached 800. This will increase the possibility of crashes due to a higher setting even on relatively high-DPI devices, but that was always already an issue.

* Also brings the custom DPI dialog box in line with the UX guidelines as per <http://koreader.rocks/doc/modules/ui.widget.confirmbox.html>.

@Frenzie Frenzie added the UX label Dec 8, 2018

@poire-z

poire-z approved these changes Dec 8, 2018

@Frenzie Frenzie merged commit e8192c8 into koreader:master Dec 8, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:custom_dpi branch Dec 8, 2018

Frenzie added a commit to Frenzie/koreader that referenced this pull request Dec 8, 2018

[UX] DPI: show concrete numbers and add more custom DPI presets
Follow-up of koreader#4388.

Implements the suggestion by @turkeyphant from <koreader#2589 (comment)>.

Also adds a little explanatory message when holding on the Auto DPI option.

Frenzie added a commit to Frenzie/koreader that referenced this pull request Dec 8, 2018

[UX] DPI: show concrete numbers and add more custom DPI presets
Follow-up of koreader#4388.

Implements the suggestion by @turkeyphant from <koreader#2589 (comment)>.

Also adds a little explanatory message when holding on the Auto DPI option.

Frenzie added a commit that referenced this pull request Dec 8, 2018

[UX] DPI: show concrete numbers and add more custom DPI presets (#4389)
Follow-up of #4388.

Implements the suggestion by @turkeyphant from <#2589 (comment)>.

Also adds a little explanatory message when holding on the Auto DPI option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment