New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when tap on external link in non-EPUB documents #4391

Merged
merged 1 commit into from Dec 10, 2018

Conversation

Projects
None yet
2 participants
@poire-z
Copy link
Contributor

poire-z commented Dec 9, 2018

Fix crash with attempt to index field 'xpointer' when taping on an external link in a PDF document.

@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Dec 9, 2018

Was this broken somewhat recently?

@poire-z

This comment has been minimized.

Copy link
Contributor

poire-z commented Dec 9, 2018

I don't think so, this must have been there for a long time, but I guess people don't hit external links in PDF often...

(Strangely, I got the crash on my Kobo - but I couldn't reproduce it on the emulator: hitting that same document area that is a link didn't trigger any link following ... might be some different combination of all the pdf settings... didn't investigate that much).

@Frenzie

This comment has been minimized.

Copy link
Member

Frenzie commented Dec 9, 2018

I've tapped 'em on purpose at least once within the past couple of years, hence why ask. But maybe that was just in EPUB, for #2493.

@Frenzie

Frenzie approved these changes Dec 9, 2018

@poire-z poire-z merged commit 8f77de8 into koreader:master Dec 10, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@poire-z poire-z deleted the poire-z:fix_pdf_external_links branch Dec 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment