New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few Kindle fixes #4394

Merged
merged 5 commits into from Dec 10, 2018

Conversation

Projects
None yet
2 participants
@NiLuJe
Copy link
Member

NiLuJe commented Dec 9, 2018

  • isWifiOn (fix #4380)
  • FL state restore on resume (esp. when off) (fix #4392)

NiLuJe added some commits Dec 9, 2018

Ensure frontlight intensity is properly restored on resume on Kindle.
Only actually matters when the frontlight is *off*.

Fix #4392
Fix unit test
Hopefully? We can't really make it bullet-prof without faking a sysfs
anyway.

The only thing to remember is that we only ever write to sysfs to set it
to 0, otherwise, lipc does the job.
@NiLuJe

This comment has been minimized.

Copy link
Member

NiLuJe commented Dec 9, 2018

This effectively means we now require a working lipc handle to set the FL, we never set it manually, unless to set it to 0.

The fallback codepath was barely useful anyway, since the sysfs values do not map to the UI range (f.g., 15 -> 775 on my PW2).

@Frenzie
Copy link
Member

Frenzie left a comment

lgtm

@NiLuJe NiLuJe merged commit f020b12 into koreader:master Dec 10, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment