New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX, Android] Hide E Ink full refresh setting on Android #4397

Merged
merged 1 commit into from Dec 12, 2018

Conversation

Projects
None yet
2 participants
@Frenzie
Copy link
Member

Frenzie commented Dec 11, 2018

Fixes confusion caused by its appearance such as in #4396.


-- TODO reactivate if someone reverse engineers Android E Ink stuff
if Device:isAndroid() then
table.insert(eink_settings_table.sub_item_table, 1, require("ui/elements/refresh_menu_table"))

This comment has been minimized.

@poire-z

poire-z Dec 11, 2018

Contributor

Shouldn't this be if not Device:isAndroid() then ?

This comment has been minimized.

@Frenzie

Frenzie Dec 11, 2018

Member

Quite so! :-D

This comment has been minimized.

@Frenzie

Frenzie Dec 11, 2018

Member

(I quickly tested on not Android and forgot to change it back.)

[UX, Android] Hide E Ink full refresh setting on Android
Fixes confusion caused by its appearance such as in #4396.

@Frenzie Frenzie force-pushed the Frenzie:meh branch from d80a89b to 474eaec Dec 11, 2018

@Frenzie Frenzie merged commit 8fec0f3 into koreader:master Dec 12, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@Frenzie Frenzie deleted the Frenzie:meh branch Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment